Skip to content

Reset locale in visitor location spec to avoid flaky specs

Peter Leitzen requested to merge pl-reset-locale into master

What does this MR do and why?

Locale is global state so we have to reset it after modifying to avoid flaky specs like:

bin/rspec --order defined \
  spec/lib/gitlab/auth/visitor_location_spec.rb \
  spec/lib/gitlab/ci/config/entry/artifacts_spec.rb

Refs !163914 (diffs, comment 2152171557)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports