Skip to content

Geo: Refactor verification_failed factory traits

Michael Kozono requested to merge mk/improve-verification-failed-factory-traits into master

What does this MR do and why?

  • Set failure message properly
  • Remove unneeded transition to verification_started. It became unneeded when we allowed transitioning to verification_failed from any initial state.
  • Switch from listing all states to specifying any state. It is clearer. And if we add a new state in the future, it is very likely that we want these transitions to be allowed from the new state as well.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

No behavior change. Geo checksumming and verification should continue to work.

Merge request reports