Move InstanceMetadata concerns under AppConfig context
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.
What does this MR do and why?
As a follow-up from !164806 (merged), in that MR we introduced the bounded context AppConfig. This commit moves some of these non-bounded modules into this domain. The modules that are moved under AppConfig concern InstanceMetadata.
-
app/models/instance_metadata.rb
should becomeAppConfig::ServerInfo
. -
app/models/instance_metadata/kas.rb
should becomeAppConfig::KasInfo
. -
app/graphql/types/metadata_type.rb
should becomeTypes::AppConfig::ServerInfoType
. -
app/graphql/resolvers/metadata_resolver.rb
should becomeResolvers::AppConfig::ServerInfoResolver
.
I also fixed some of the Rubocop offenses in these files and therefore removed the corresponding entries from .rubocop_todo/**/*
.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
I did not make UI changes.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
I only moved files. The pipeline should still succeed.
See also !164806 (comment 2087502138)
Related to #482810