Skip to content

Move wiki page concerns back inside models

Piotr Skorupa requested to merge psk-move-wiki-page-concerns-back-to-models into master

What does this MR do and why?

In !48755 (merged) the majority of WikiPage::Meta and WikiPage::Slug models logic was moved to concerns in preparation for adding new entities for group wikis that would share that code.

This MR reverts these efforts.

The original issue description in #216904 (closed) posited separating group wikis into separate models and tables, and this is something contrary to the direction we've been going the last few years with consolidating other entities (epics into work items, groups and projects into namespaces). It doesn't seem to solve any problems, so we're going to abandon this approach and no longer separate project- and group-level wikis in that way at the database level.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Piotr Skorupa

Merge request reports

Loading