Make "Add to Review" be the primary MR Overview button
What does this MR do and why?
For #479269
This does what the title says, but there are some implications of that:
- There's no ability to "create a thread"
- ...which means there's no split/dropdown comment button
- The "Add comment now" button always shows, since we don't specifically check for the existence of drafts any more
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After | |
---|---|---|
No Content | ||
w/ Note | ||
No Content (internal) | ||
w/ Note (internal) |
Additionally, because there was a strange test failure with the "r" (reply) keyboard shortcut, here is the "r" keyboard shortcut working identically to how it works on master
.
Screencast_from_2024-10-23_14-37-08
How to set up and validate locally
- Create an MR
-
👀 at the comment field on the main ("Overview") tab of the MR.
Edited by Thomas Randolph