Skip to content

Make "Add to Review" be the primary MR Overview button

Thomas Randolph requested to merge tor/feature/overview-primary-add-to-review into master

What does this MR do and why?

For #479269

This does what the title says, but there are some implications of that:

  • There's no ability to "create a thread"
  • ...which means there's no split/dropdown comment button
  • The "Add comment now" button always shows, since we don't specifically check for the existence of drafts any more

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
No Content before_none_public after_none_public
w/ Note before_some_public after_some_public
No Content (internal) before_none_private after_none_private
w/ Note (internal) before_some_private after_some_private

Additionally, because there was a strange test failure with the "r" (reply) keyboard shortcut, here is the "r" keyboard shortcut working identically to how it works on master.

Screencast_from_2024-10-23_14-37-08

How to set up and validate locally

  1. Create an MR
  2. 👀 at the comment field on the main ("Overview") tab of the MR.
Edited by Thomas Randolph

Merge request reports