Skip to content

Remove policy_scope check to stop N+1 queries

Sashi Kumar Kumaresan requested to merge sk/remove-scope-check into master

What does this MR do and why?

This change removes the policy scope check in Security::SyncPolicyWorker to reduce the N+1 queries caused by Security::SecurityOrchestrationPolicies::PolicyScopeChecker that loads compliance_framework_settings and group. We anyway do the policy.scope_applicable?(project) check in Security::SecurityOrchestrationPolicies::SyncProjectService, so it does not break the feature.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports