Skip to content

History rewrite: handle Gitaly errors

Vasilii Iakliushin requested to merge 481484_restructure_cleanup_service into master

What does this MR do and why?

Contributes to #483085 (closed)

Problem

There is no handling for Gitaly related errors. Because of that RewriteHistoryService will raise an error instead of returning a ServiceResponse object.

Solution

  • Add Gitaly error handling for #rewrite_history to RepositoryCleaner class
  • Use RepositoryCleaner in RewriteHistoryService instead of directly calling Gitaly client.
  • Add tests for Gitaly error handling.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

redact-text-2

How to set up and validate locally

  1. Enable feature flag Feature.enable(:async_rewrite_history)
  2. Follow Remove blobs guidance
  3. Check latest emails: http://gdk.test:3000/rails/letter_opener
Edited by Vasilii Iakliushin

Merge request reports