Fix sidekiq warning for MergeRequests::RemoveUserApprovalRulesWorker
requested to merge gitlab-community/gitlab:497113-sidekiq-warning-merge-requests-remove-user-approval-rules-worker into master
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.
What does this MR do and why?
This MR addresses the sidekiq warning that appears for the worker MergeRequests::RemoveUserApprovalRulesWorker, see below.
Job arguments to MergeRequests::RemoveUserApprovalRulesWorker must be native JSON types, but {"project_id"=>102, "user_ids"=>[240]} is a ActiveSupport::HashWithIndifferentAccess.MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
| Before | After |
|---|---|
| The test output contains a sidekiq warning. | The test output does not contain a sidekiq warning. |
How to set up and validate locally
- In this MR, run the following test. You will not see the sidekiq warning.
bundle exec rspec spec/requests/api/maven_packages_spec.rb:463- Run the test again in the branch
master. You will see the sidekiq warning.
Related to #497113
Edited by Gerardo Navarro