Skip to content

Avoid SELECT 1/LIMIT 1 query in credentials inventory

Drew Blessing requested to merge dblessing_cred_inv_query_fix into master

What does this MR do and why?

Avoid SELECT 1/LIMIT 1 query in credentials inventory

When the query hasn't yet loaded and the view does something like credentials.empty?, ActiveRecord executes a SELECT 1/LIMIT 1 query. If that empty call returns false then the view loads up all the credentials to display them. This query is not performant so we explcitly call load in controller actions to avoid this query.

Fixes #500097 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports