Skip to content

Add noteable context to Note keep-around metrics

James Fargher requested to merge note_keep_around_context into master

What does this MR do and why?

#500160

I've been trying to come up with an architecture for replacing keep-around references with scoped refs. We currently have prometheus metrics to tell us what models are creating these refs, but notes can be associated with a few different things. To help me finalise things here I'm adding this noteable type to the keep-around metrics.

Keep-arounds are disabled in tests and we don't seem to currently have any assertions. Since this is just for metrics labels I'm not too worried.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports

Loading