Skip to content

Finalize BackfillRootNamespaceClusterAgentMappings migration

Daniyal Arshad requested to merge da-finalize-backfill-root-namespace-cluster-mappings-migration into master

Issue: Delete remote_development_agent_configs table (#480767)

What does this MR do and why?

Why this is needed This MR finalizes the BackfillRootNamespaceClusterAgentMappings background migration.

Finalization of old background migrations is a pre-requisite for safe removal of old migration code & its specs to ensure that said migration has completed. See: Finalize a background migration

Related to:

Where spec for this old background migrations fails when we try to remove the remote_development_agent_configs in the MR above.

  • ee/spec/lib/ee/gitlab/background_migration/backfill_root_namespace_cluster_agent_mappings_spec.rb

So as a pre-requisite to dropping the table, we first need to finalize this migration and pin the spec to the finalization migration version. And then delete the table in a following release to ensure that there are no self managed instances that still have this background migration running and provide a safe upgrade path when we drop the remote_development_agent_configs in a following release.

What it does Finalize BackfillRootNamespaceClusterAgentMappings migration

  • Adds a post migration to ensure background migration is finished
  • Updates finalized_by in background migration doc
  • Pins the spec for BackfillRootNamespaceClusterAgentMappings to the finalized schema version in this MR

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

This MR does not include any UI changes

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Daniyal Arshad

Merge request reports