Remove `<gl-modal-vuex />`
What does this MR do and why?
This MR removes <gl-modal-vuex /> from vue_shared and ultimately, the codebase.
There was only one usage of it in the codebase, it was much more complicated than it needed to be, and it was causing Vue3 tests to fail.
This MR should keep exactly the same functionality as the previous implementation, just with less code. If not, something needs changing.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Everything is the same before and after, here's a video to prove it:
Screen_Recording_2024-10-24_at_10.24.14
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Go to a project
- Got to settings > merge requests > merge request approvals
- Add an approval rule
- Hit the delete button to see the modal we're testing