Skip to content

Move base integration code to a separate module

George Koltsov requested to merge georgekoltsov/instance-integration-models-pt-1 into georgekoltsov/update-instance-integrations-table

What does this MR do and why?

⚠ Depends on !170247

This MR extracts functionality from Integration model into a separate Base::Integration module in order to be used in both Integration & Instance::Integration models. It's needed in order to support the Cells architecture & to move instance integrations out of integrations db table into it's own instance_integrations table. For this, we need a new Instance::Integration model that has the same functionality but persists records to the new table.

This MR:

  • Creates a new Base::Integration module to be shared between the two models
  • The moved code is the same as it was before, with the only additions of disabling rubocop rules to make CI green. We can tackle rubocop offenses in follow up MRs

Mentions #474809

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by George Koltsov

Merge request reports