Skip to content

Refactor base changes auditor subclasses

Andrew Jung requested to merge 463570/refactor-base-changes-auditor-classes into master

What does this MR do and why?

  • Move BaseAuditorClass to AuditEvents (from Audit) and the rest of the inherited classes to their appropriate bounded context
  • Update rubocop files with updated paths
  • Create new folders for modules that don't exist yet in ee/lib/
  • I have also moved classes that did not inherit from the base class but still lived in ee/lib/audit to their module, for example ArtifactDownloadAuditor to ci/

Mappings:

Class Name Bounded Context Alternative Bounded Context?
ProjectAnalyticsChangesAuditor Analytics Projects
ApplicationSettingChangesAuditor AppConfig
UnauthenticatedSecurityEventAuditor Authn
ArtifactDownloadAuditor Ci
ComplianceFrameworkChangesAuditor ComplianceManagement
ProtectedEnvironmentAuthorizationRuleChangesAuditor Environments
ExternalStatusCheckChangesAuditor MergeRequests
GroupMergeRequestApprovalSettingChangesAuditor MergeRequests
MergeRequestDestroyAuditor MergeRequests Issuables
MergeRequestBeforeDestroyAuditor MergeRequests Issuables
GroupChangesAuditor Namespaces
NamespaceSettingChangesAuditor Namespaces AppConfig
ProjectSettingChangesAuditor Projects
ProjectCiCdSettingChangesAuditor Projects Ci
ProjectFeatureChangesAuditor Projects
ProjectChangesAuditor Projects
ProjectSecuritySettingChangesAuditor Projects Security
BasePushRulesChangesAuditor Repositories
GroupPushRulesChangesAuditor Repositories
ProjectPushRulesChangesAuditor Repositories
ProtectedBranchesChangesAuditor Repositories
UserSettingChangesAuditor Users
Available bounded contexts (from: `config/bounded_contexts.yml`)
  • Ai
  • Analytics
  • AntiAbuse
  • AppConfig
  • AuditEvents
  • Authn
  • Authz
  • Backup
  • Boards
  • Ci
  • CloudConnector
  • Clusters
  • CodeSuggestions
  • ComplianceManagement
  • ContainerRegistry
  • DependencyProxy
  • DesignManagement
  • Environments
  • Geo
  • GitlabSubscriptions
  • Import
  • Integrations
  • Issuables
  • Members
  • MergeRequests
  • MergeTrains
  • Ml
  • Namespaces
  • Nav
  • Notes
  • Observability
  • Onboarding
  • Organizations
  • Packages
  • Pages
  • Projects
  • ResourceAccessTokens
  • Releases
  • RemoteDevelopment
  • Repositories
  • Sbom
  • Search
  • SecretsManagement
  • Security
  • ServiceDesk
  • ServicePing
  • Snippets
  • StatusPage
  • Terraform
  • Todos
  • Users
  • Utilization
  • VirtualRegistries
  • Vulnerabilities
  • WebHooks
  • WebIde
  • Wikis
  • WorkItems

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

Addresses: #463570

Edited by Andrew Jung

Merge request reports