Skip to content

Fix double line number hash on pipeline security tab

What does this MR do and why?

Related #498464

Fix double line number hash on pipeline security tab

This fixes an issue where the link to a line number in a file on the pipeline security tab can contain the hash for the line number(s) twice.

Changelog: fixed EE: true

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2024-10-25_at_09.17.10 Screenshot_2024-10-25_at_09.15.59

How to set up and validate locally

  1. Import https://gitlab.com/gitlab-examples/security/security-reports
  2. Run pipeline on master
  3. Go to pipeline > security tab
  4. Find a finding with a file link with a line number (e.g. secrets.go:114)
  5. Validate that the link contains the hash only once #L114

Merge request reports

Loading