Skip to content

Update alert to show warning for group branch mod

Alexander Turinske requested to merge 435725-fix-override-alert into master

What does this MR do and why?

Update alert to show warning for group branch mod

  • the group branch modification setting can be an object instead a boolean like the other settings
  • the alert shows that the policy is empty if only this setting is set
  • update alert for this use case
  • update tests

Changelog: changed

EE: true

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
alert_-_b Screenshot_2024-10-25_at_10.17.27 Screenshot_2024-10-25_at_10.17.44 Screenshot_2024-10-25_at_10.17.50 Screenshot_2024-10-25_at_10.18.04

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Enable the feature flag echo "Feature.enable(:scan_result_policy_block_group_branch_modification)" | rails c
  3. Navigate to a group => Secure => Policies => New policy => Merge request approval policy
  4. Verify the Block group branch modification setting shows and can be toggled and modified and the alert shows as expected

Related to #435725 (closed)

Merge request reports