Draft: Fix PipelineNotificationWorker args do not serialized to JSON safely
requested to merge gitlab-community/gitlab:383183-fix-pipelinenotificationworker-args-do-not-serialize-to-json-safely into master
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.
What does this MR do and why?
Fix #383183
... for the PipelineNotificationWorker
part, namely this warning:
Job arguments to PipelineNotificationWorker must be native JSON types, but :ref_status is a Symbol.
See https://github.com/sidekiq/sidekiq/wiki/Best-Practices
To disable this error, add `Sidekiq.strict_args!(false)` to your initializer.
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
This issue is common across many workers. See #383181 (closed).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- On
master
branch, runbundle exec rspec spec/models/ci/pipeline_spec.rb:3970:4012 --format documentation
to see the warning - Checkout this MR, run
bundle exec rspec spec/models/ci/pipeline_spec.rb:3970:4012 --format documentation
again to see the warning disapear
Related to #383183
Edited by Chou Yu Ta