Skip to content

Add tabs under a new feature flag

Chen Charnolevsky requested to merge 493263-add-details-to-drawer-P2 into master

What does this MR do and why?

According to this task, this MR is one of the development stages.

In this MR we add tabs: 'details' and 'code flow' under a new feature flag called: mr_vulnerability_code_flow

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Upload a GitLab Ultimate license
  2. Create an empty project
  3. Go to your locally project and edit with web IDE
  4. Create a new file called: gl-sast-report.json and copy the content from here: gl-sast-report.json
  5. Create a new file .gitlab-ci.yml and pasted this content: gitlab-ci.yml
  6. Create a new folder called app and a new file inside called app.py and pasted this content: app.py
  7. Create a new MR
  8. Go into 'Changes' in your MR and you will see the detected vulnerability using shapes next to the specific rows.
  9. Click on it and the 'drawer' will open in the right side of the screen.
  10. Validate you will see all the current data under 'Details' tab
  11. Scroll down and validate you see a new button called View code flow, validate it's navigates the user to the Code flow tab
  12. Move between 'Details' and 'Code flow' by clicking on the current tab.

Numbered steps to set up and validate the change are strongly suggested.

Related to #493263

Merge request reports