Skip to content

Monitor charts: Validate form for creating an alert before submitting

What does this MR do?

Fixes issues with alert modals described in #31904 (closed)

  • Prevents triggering a premature modal dismissal on errors
  • Prevents errors from disabling fields in alert modal
  • Selects a default operator to help the user make the right choice
  • Places the error message with correct spacing

Please review with environment_metrics_additional_panel_types FF on

Screenshots

before after
Error dismissed modal, locked the modal fields 2019-09-20_00.53.13 Error handling in modal image
User must select operator on new alert 2019-09-20_00.55.39 Default operator set on new 2019-09-26_11.21.12
image Error message in modal and panel (left in panel if the error occurs on load 2019-09-26_11.19.51

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Related to #31904 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading