Skip to content

Add param filtering to avoid error while saving project settings

Gosia Ksionek requested to merge mk-patch-project-settings into 17-5-stable-ee

What does this MR do and why?

When ancestor group or instance is locking duo features settings, there is a bug when you cannot save any project settings changes. It is caused by validation: we are sending duo_features_enabled param from projects form, then validation is returning an error. As in this case we cannot change this particular param, the easiest thing to do is to filter this param out when ancestor locked Duo features.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

solves #490336 (closed)

Edited by Gosia Ksionek

Merge request reports

Loading