Skip to content

Include last contacted time on audit log when runner is deleted

What does this MR do and why?

This MR changes the code to include the last contacted time on audit log when a runner is deleted. This makes it possible to check if the runner was stale by the time it was removed, as the runner record will have been deleted from the database by then and we will not have another way of checking.

Changelog: changed EE: true

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Remove a runner from the list at http://gdk.test:3000/admin/runners, taking note of the last contact time
  2. Check that the event was created at http://gdk.test:3000/admin/audit_logs, with the corresponding contact time
Edited by Pedro Pombeiro

Merge request reports

Loading