Skip to content

Remove deprecated AuditEventService from RunnerAuditEventService

Pedro Pombeiro requested to merge pedropombeiro/507783/remove-audit_event_service-from-runner_audit_event_service into master

What does this MR do and why?

This MR removes the deprecated AuditEventService from RunnerAuditEventService, as suggested in the documentation.

EE: true

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to http://gdk.test:3000/admin/runners and register a new runner (using the runner registration token hidden in the kebab menu):

    gitlab-runner register --url http://gdk.test:3000  -t $YOUR_TOKEN --non-interactive --executor shell --config ~/.gitlab-runner/config.gdk.toml

  2. Check that the event was logged in http://gdk.test:3000/admin/audit_logs

  3. This can be repeated at the group (e.g. http://gdk.test:3000/groups/gitlab-org/-/runners) and project level (e.g. http://gdk.test:3000/gitlab-org/gitlab-test/-/settings/ci_cd).

Edited by Pedro Pombeiro

Merge request reports