Skip to content

Draft: Add more DAST variables to dast_variables.js

Miranda Fluharty requested to merge 509057-just-add-variables-to-existing-file into master

What does this MR do and why?

Adds the rest of the DAST configuration CI/CD variables to the defined list of dast_variables that we use in the Additional variables => Add variable modal's Variable key dropdown.

This excludes variables already covered in the form:

DAST_TARGET_URL

DAST_SCOPE_EXCLUDE_URLS, DAST_REQUEST_HEADERS,

DAST_AUTH_URL,
DAST_AUTH_USERNAME_FIELD, DAST_AUTH_PASSWORD_FIELD,
DAST_AUTH_USERNAME, DAST_AUTH_PASSWORD,
DAST_AUTH_SUBMIT_FIELD,

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screen_Recording_2024-12-18_at_20.12.48 Screen_Recording_2024-12-20_at_14.15.29

How to set up and validate locally

git checkout 509057-just-add-variables-to-existing-file
echo "Feature.enable(:dast_ui_additional_variables)" | gdk rails c
  1. create a scanner profile http://gdk.test:3000/flightjs/Flight/-/security/configuration/profile_library/dast_scanner_profiles/new
  2. add Additional variables to it
  3. confirm that all of the DAST configuration CI/CD variable keys are in the dropdown (aside from the ones that are already covered in the form)

Related to #509057

Edited by Miranda Fluharty

Merge request reports