Revert ElasticsearchSettingsFromApplicationSettings migration
Purpose of revert
This MR is a partial revert of MR: !174172 (merged). The post deploy migration caused an incident which has resolved on GitLab.com. The post deployment migration is being reverted to prevent downtime for self managed and dedicated deployments. It should be safe to revert the post deployment migration because the original MR was deployed on 2024-12-20 without the post deployment migration being run and no errors were observed.
The MR only reverts the post deployment migration, but leaves the new JSONB fields. The migration will be reintroduced in #511921 and will only be run if the columns exist.
The revert includes:
- making the migration a no-op
- reverting the
.ymlfiles for removed columns - updated structure.sql
- migration to re-add the columns only if they do not exist
- migration to backfill the old columns from jsonb field
Testing
I tested the behavior of the UI with the revert. The UI and application read happens from the elasticsearch JSONB column. I changed the value of the elasticsearch_search and elasticsearch_indexing columns from psql and the UI did not change. When the values were updated, both the elasticsearch JSONB field AND the deprecated columns were updated.
Checklist
-
Create an issue to reinstate the merge request and assign it to the author of the reverted merge request. Reinstate ElasticsearchSettingsFromApplicationS... (#511921) - [-] If the revert is to resolve a broken 'master' incident, please read through the Responsibilities of the Broken
masterresolution DRI. -
If the revert involves a database migration, please read through Deleting existing migrations. -
Add the appropriate labels before the MR is created. We can skip CI/CD jobs only if the labels are added before the CI/CD pipeline is created.
Milestone info
-
I am reverting something in the current milestone. No changelog is needed, and I've added a ~"regression:*"label. -
I am reverting something in a different milestone. A changelog is needed, and I've removed the ~"regression:*"label.
Related issues and merge requests
Issue: #511924
Incident: gitlab-com/gl-infra/production#19079 (comment 2283342105)
MR: Consolidate Elasticsearch application settings ... (!174172 - merged)