Avoid partial failures in API calls due to bugs in auditing code
What does this MR do and why?
This MR introduces logic to avoid partial failures in API calls due to bugs in auditing code. This is a corrective action for 2 recent incidents (gitlab-com/gl-infra/production#18984 (closed) and the related https://gitlab.com/gitlab-com/gl-infra/production/-/issues/18994). The idea is that if an action is executed, and the auditing code for some reason has a bug, then we should avoid creating a wrong picture for the API user, where we return and error when the action was successful, or vice-versa. The approach taken here corresponds to #509082.
For context, the original problem was that the Gitlab::Audit::CiRunnerTokenAuthor class was missing the #impersonated? method, so tracking that event caused a NoMethodError.
Changelog: fixed
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
n/a
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
The added specs should be sufficient to test the behavior.