Skip to content

Remove unnecessary attributes from icon.vue

Mike Greiling requested to merge mg-refactor-icon-component into master

What does this MR do?

Removes a bunch of unnecessary attributes from the <icon> Vue component.

  • cssClasses is redundant because class values are merged with the root element anyway. All instances of css-classes= have been replaced with class=.
  • width, height, x, y are redundant and will all pass through. No changes needed.
  • tabIndex is redundant because tabindex can be passed through. All instances of tab-index have been replaced with tabindex

I've also removed aria-hidden="true" because should be explicitly added when needed. There are many instances of <icon> components that had aria-label="" attached to it which were being unknowingly overridden by the aria-hidden attribute.

Merge request reports