Remove unnecessary attributes from icon.vue
What does this MR do?
Removes a bunch of unnecessary attributes from the <icon>
Vue component.
-
cssClasses
is redundant becauseclass
values are merged with the root element anyway. All instances ofcss-classes=
have been replaced withclass=
. -
width
,height
,x
,y
are redundant and will all pass through. No changes needed. -
tabIndex
is redundant becausetabindex
can be passed through. All instances oftab-index
have been replaced withtabindex
I've also removed aria-hidden="true"
because should be explicitly added when needed. There are many instances of <icon>
components that had aria-label=""
attached to it which were being unknowingly overridden by the aria-hidden
attribute.