Related issues FE Base
What does this MR do?
Previous monolithic MR, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1739
-
1. Add IssueToken
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1798 -
1.5. Add enableMap
togl.GfmAutoComplete
for partial re-use, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1800 -
2. Add AddIssuableForm
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1799 -
3. Add RelatedIssuesService
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1801 -
3.5. Add IssuableReferenceUtility
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1803 -
4. Add RelatedIssuesStore
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1802 -
5. Add RelatedIssuesBlock
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1814 -
6. Add basic RelatedIssuesRoot
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1815 -
7. Add input processing methods to root, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1816 or simpler https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2050
Are there points in the code the reviewer needs to double check?
- FE architecture: https://gitlab.slack.com/archives/C4GFEUG90/p1492701050309816
https://drive.google.com/file/d/0B4cjIdQwaPXhV05jWWxiVWs0X28/view?usp=sharing
If you would like to try out related issues, checkout https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2050 on EE
Go to https://license.gitlab.com/ and "manually create" with a Premium plan. Leave the user count blank and expiration as a template for infinite (edited)
After you have the license, you can paste it into http://localhost:3010/admin/license
Visit an issue page to see the related issues block
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
Todo
-
1. Wait for return of all related issues on every interaction, POST
,DELETE
-
2. Wait for namespace
,project
, andiid
instead ofreference
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1803#note_28770379-
Waiting on project_path
instead ofproject_full_path
, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1719/diffs#note_28875114
-
-
3. Wait for endpoint for fetching issue info by reference or URL -
4. Wait for id
on BE issue response, see https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1816#note_28925605 -
Figure out the transient 422 Unprocessable Entity
->InvalidAuthenticityToken
when interacting with some related issues endpoints-
X-CSRF-Token
is in place andvue_resource_interceptor
definitely fires - It seems like the CSRF token is getting invalidated somehow
- Seems like an issue with using
localhost
when you are using a0.0.0.0
host. Need to use your actual local network IP192.168.1.135
when browsing.
-
-
Add some overview rspec tests -
Add some docs to link in the header
Notes
Combine multiple MR/branches into a chunk
Steps 1-5
# Combine all commits into a list
{
git log --reverse 2001-related-issues-fe-base..related-issues-fe-issue-token-step-1 --format="%H";
git log --reverse related-issues-fe-issue-token-step-1..related-issues-fe-add-issuable-form-step-2 --format="%H";
git log --reverse 2001-related-issues-fe-base..related-issues-fe-add-store-step-4 --format="%H";
git log --reverse 2001-related-issues-fe-base..related-issues-fe-related-issues-block-step-5 --format="%H";
} |
sed ':a;N;s/\n/ /;ba' |
# Make the list unique
uniq |
# Cherry-pick everything
# If you want to dry-run: xargs -L1 echo git cherry-pick
xargs -L1 git cherry-pick
What are the relevant issue numbers?
Closes #2001 (closed)
Edited by Eric Eastwood