Skip to content

Aggregate push events when there are too many

Patrick Bajao requested to merge 31007-limit-activity-events into master

What does this MR do?

Implements the functionality to aggregate push events as one push event when number of changes for branches and tags in a single push exceeds 3 (by default, configurable via push_event_activities_limit).

This way, if there are a lot of changes in a single push (e.g. 10000 branches/tags), we won't need to create multiple events to prevent having our system bogged down and to not spam the activity feed.

Screenshots

Admin setting

Before

Screen_Shot_2019-10-11_at_1.29.43_PM

After

Screen_Shot_2019-10-11_at_1.25.26_PM

Activity feed

Before

Screen_Shot_2019-10-11_at_1.31.11_PM

After

Screen_Shot_2019-10-09_at_2.40.08_PM

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#31007 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading