Skip to content

HTML-escape search term in empty message

Markus Koller requested to merge 33668-fix-search-term-xss into master

What does this MR do?

Fixes the XSS vulnerability from #33668 (closed)

As discussed with @jeremymatos we're submitting this MR publicly, as the vulnerability is only in master and not released yet.

/cc @gitlab-com/gl-security/appsec

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading