Skip to content

Update quarantined test so that it runs (although it's still quarantined)

Mark Lapierre requested to merge ml-qa-update-project-templates-test into master

What does this MR do?

While working on another MR I noticed that a quarantined test had a bug:

1) manage Project templates instance level successfully imports the project using template
     Failure/Error: Page::Admin::Menu.perform(&:go_to_template_settings)
     
     ArgumentError:
       wrong number of arguments (given 0, expected 1)
     # ./qa/page/admin/menu.rb:96:in `within_submenu'
     # ./qa/ee/page/admin/menu.rb:46:in `block in go_to_template_settings'
     # ./qa/page/admin/menu.rb:86:in `block in hover_element'
     # ./qa/page/admin/menu.rb:92:in `block in within_sidebar'
     # ./qa/page/base.rb:149:in `block in within_element'
     # /usr/local/bundle/gems/capybara-2.16.1/lib/capybara/session.rb:343:in `within'
     # ./qa/page/base.rb:148:in `within_element'
     # ./qa/support/page/logging.rb:138:in `within_element'
     # ./qa/page/admin/menu.rb:91:in `within_sidebar'
     # ./qa/page/admin/menu.rb:82:in `hover_element'
     # ./qa/ee/page/admin/menu.rb:45:in `go_to_template_settings'
     # ./qa/scenario/actable.rb:16:in `perform'
     # ./qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb:81:in `block (4 levels) in <module:QA>'

This changes fixes the test, although it stays in quarantine because the issue for the bug in the application is still open.

This change also updates the block args so the cop doesn't have to be disabled.

Does this MR meet the acceptance criteria?

Conformity

Merge request reports