Skip to content

Redirect Admin > Settings > Geo TO Admin > Geo > Settings

Zack Cuddy requested to merge 31938-move-geo-settings into master

What does this MR do?

Closes #31938 (closed)

This MR redirect the Geo Settings from the Application Settings to the Geo view in the Admin pane.

Also the notice designs do not match the mock in the issue. I am not sure if that is intended or not.

Extended the ApplicationSettings Controller into a new Geo Settings controller to handle the interactions going forward. Once we are ready we can remove the redirect from the ApplicationSettings Controller (#36896 (closed)).

Screenshots

Primary Active Nav (Geo): Primary_Active__Geo_

Primary Flyout Nav (Geo): Primary_Flyout__Geo_

Secondary Active Nav (Geo): Secondary_Active__Geo_

Secondary Flyout Nav (Geo): Secondary_Flyout__Geo_

Redirect GIF: Redirect

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Thank you @mkozono and @brodock for the help with this!

Closes #31938 (closed)

Edited by Zack Cuddy

Merge request reports

Loading