Skip to content

Add --tiller-namespace to helm commands in scripts

Albert Salim requested to merge 36022-review-app-deployment-fails-with-error-upgrade-failed-has-no-deployed-releases into master

Add --tiller-namespace to helm commands used in review-apps.sh scripts. Without the namespace, the commands could get incorrect result. For example, helm status will not find a release that is in a --tiller-namespace=review-apps-ee.

  • delete_release
  • previous_deploy_failed

delete_release is called in review-stop job, which in turn is used in .review-workflow-base environment.on_stop. This means the release may not have been deleted when the environments are stopped.

Edited by Albert Salim

Merge request reports