Refactor code to substitute variables in Prometheus queries
What does this MR do?
Refactor the code for substituting variables in Prometheus queries.
Changes this MR contains:
-
Create service for substituting variables using the Ruby interpolation format (
string_%{variable}_string
)
app/services/template_engines/ruby_service.rb
. -
Create service for substituting variables in the params of the Prometheus Proxy API. This is in preparation for adding support for the Liquid template format in !20793 (merged).
app/services/prometheus/proxy_variable_substitution_service.rb
Issue: #35242 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
Changelog entry-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides Database guides-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖