Remove environment_logs_use_vue_ui feature flag and corresponding code
What does this MR do?
Background
As part of the Monitoring stage direction and goal of moving logging to viable. We decided to use VueJS to leverage GitLab UI components and align with our design system for the "Pod Logs" page. Previously, the Logs page was done using HAML and jQuery.
The rewrite work was done behind a feature flag environment_logs_use_vue_ui at #33537 (closed) with 3 MRs (!19000 (merged), !19013 (merged), !18567 (merged)) during %12.5.
The rewrite that took place had a minimum impact in the UI, and kept all the previous elements and user interactions.
Summary: This page has been rewritten in Vue, this MR removes the HAML/jQuery code.
Implementation
This MR addresses the last cleanup step as described in #34306 (closed), in which the feature flag is dropped, and the VueJS counterpart is set as the default for users.
Remove environment_logs_use_vue_ui feature flag as if set to true and corresponding unused code.
- Remove old haml and jquery based feature files
- Update spec to use new
js-*classes - Extend feature spec to include the new dropdown
- Remove unused scrolling class
Note: ee/spec/features/projects/environments_pod_logs_spec.rb was extended changed and passes as feature is very similar.
Screenshots
| before | after* |
|---|---|
 |
 |
| *Some new icons are available in Vue, so those are used. |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines - [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #34306 (closed)