Skip to content

WIP: Remove duplicate footer from MR approved/unapproved emails

Michelle Gill requested to merge mgill/1898 into master

What does this MR do?

When an MR is approved or unapproved, an email is sent off that has 2 footers:

image

This is unlike other emails such as this one:

Screen_Shot_2017-03-13_at_1.41.45_PM_copy

MRs use a different template. I am not yet sure what this change impacts and will need to test the other emails.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michelle Gill

Merge request reports

Loading