Add ability to edit Group Hooks
What does this MR do?
- Add ability to edit Group Hooks.
- Make the UI consistent across Project / Group / Admin Hooks (at least on index pages) by extracting shared partials and DRY-ing up the code.
- Add / update specs and improve code / missing translations around old code.
Screenshots
Comparing before / after of the webhooks pages for project / group / admin levels
Section | Before | After |
---|---|---|
Project | ||
Group | ||
Admin |
New Group Hooks Edit page
(I wasn't really sure on the breadcrumbs naming so I reused what was in the other pages. Not sure if we have any guidelines about it)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖