Skip to content

Refactor to not copy from original method

Thong Kuah requested to merge refactor_knative_set_initial_status into master

What does this MR do?

Refactor Knative#set_initial_status to not copy from original method

Instead we can call the original method if the cluster is RBAC. The original method already checks if helm is available, and that it is not not_installable

Existing specs cover this in https://gitlab.com/gitlab-org/gitlab/blob/71c398d03b6ee6993160815528c801319076da83/spec/models/clusters/applications/knative_spec.rb#L26-31

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading