Cleanup container CSS for Geo Nodes
This is part of the effort listed here: #10947 (comment 254810775)
What does this MR do?
This MR is part of an effort to replace ee/app/assets/stylesheets/pages/geo_nodes.scss
with utility classes. In the process doing this will also remove the 16 lint warnings about this file. Looking through the file it is mostly colors and fixed margins. Both of which can be solved using utility classes.
This MR is my attempt at breaking it down so the screenshot diffs do not get too out of hand. At first glance this MR is small in the changes it commits, however, it removes a container used at the top of every view. Doing so there are a lot of screenshot diffs with just this change.
The main noticeable changes in this MR is a few areas get a little more spacing. This brings them more uniform however, with the global classes instead of a custom amount of spacing. So in this case I think it is appropriate.
Geo - Nodes | Geo - New Node | |
---|---|---|
before | ||
after |
Geo - Settings | Geo - Designs | |
---|---|---|
before | ||
after |
Geo - Projects | Geo - Uploads | |
---|---|---|
before | ||
after |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team