Skip to content

Remove Geo Project/Upload Custom CSS

Zack Cuddy requested to merge cleanup-geo_node-extra-css into master

Closes #10947 (closed)

What does this MR do?

This MR is part of an effort to replace ee/app/assets/stylesheets/pages/geo_nodes.scss with utility classes. In the process doing this will also remove the 16 lint warnings about this file. Looking through the file it is mostly colors and fixed margins. Both of which can be solved using utility classes.

The main goal of this MR is to focus on the CSS related to the Geo Projects and Geo Uploads sections. These are simple lists with only a few custom styles, so cleaning it up didn't take too much additional CSS. However, it did spread across quite a few files.

Screenshots

Geo Projects Geo Uploads Item w/ Dropdown
before Geo_Projects_-_Old Geo_Uploads_-_Old Geo_Item_with_Dropdown_-_Old
after Geo_Projects_-_New Geo_Uploads_-_New Geo_Item_with_Dropdown_-_New
Chevron Collapsed Cevron Expanded
before Project_Errors_Collapsed_-_Old Project_Errors_Expanded_-_Old
after Project_Errors_Collapsed_-_New Project_Errors_Expanded_-_New

No more linting errors: Screen_Shot_2019-12-11_at_9.35.35_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports

Loading