Fix Namespace.find_by_pages_host
What does this MR do?
With #28781 (closed) we introduced Namespace.find_by_pages_host
.
Currently it behaves incorrectly - if we have namespace foo.io
then Namespace.find_by_pages_host("foo.io")
will return the namespace which is, this should happen only when looking for foo.io.gitlab.io
(or whatever is the configured domain for Pages).
This MR fixes this by making sure we perform the lookup only if the provided host end with the domain configured for Pages.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński (Back 2025-01-01)