Skip to content

Fix Namespace.find_by_pages_host

Krasimir Angelov requested to merge fix-namespace-find-by-pages-host into master

What does this MR do?

With #28781 (closed) we introduced Namespace.find_by_pages_host.

Currently it behaves incorrectly - if we have namespace foo.io then Namespace.find_by_pages_host("foo.io") will return the namespace which is, this should happen only when looking for foo.io.gitlab.io (or whatever is the configured domain for Pages).

This MR fixes this by making sure we perform the lookup only if the provided host end with the domain configured for Pages.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński (Back 2025-01-01)

Merge request reports

Loading