Skip to content

Verify override for helpers and other prepended modules

Lin Jen-Shin requested to merge 39499-helper-overriden-method-doesn-t-seem-to-trigger-override-violation into master

What does this MR do?

Always check override where prepend happens

Because otherwise helpers won't be verified, and since we're using prepend to override direct methods mostly, it should work anyway.

We also skip instrumentation when we're doing static verification.

Also we need to move some methods from EE::Gitlab::GeoGitAccess to EE::Gitlab::GitAccessWiki, because that's where it's trying to override methods, not in geo itself.

This also assumes GitAccessWiki does not use those methods, of course. It won't work anyway, because it's not getting methods from Gitlab::GitAccessWiki!

This affects the following modules:

  • LfsRequest
  • Gitlab::Patch::DrawRoute
  • Participable
  • Mentionable
  • Issuable
  • Noteable
  • ProjectsHelper
  • ApplicationSettingsHelper
  • API::Helpers
  • API::APIGuard::HelperMethods
  • Gitlab::Auth::AuthFinders
  • API::Helpers::CommonHelpers
  • API::Helpers::ProjectsHelpers
  • API::Helpers::ProjectSnapshotsHelpers
  • ProtectedRefAccess
  • API::Helpers::Runner
  • OnboardingExperimentHelper
  • ApplicationHelper
  • API::Helpers::UsersHelpers
  • AppearancesHelper
  • AuthHelper
  • AwardEmojiHelper
  • BoardsHelper
  • ButtonHelper
  • ClustersHelper
  • DashboardHelper
  • EmailsHelper
  • EventsHelper
  • ExportHelper
  • GroupsHelper
  • Groups::GroupMembersHelper
  • IssuablesHelper
  • IssuesHelper
  • KerberosSpnegoHelper
  • NavHelper
  • NotesHelper
  • PreferencesHelper
  • RecaptchaExperimentHelper
  • SearchHelper
  • SortingHelper
  • SystemNoteHelper
  • TabHelper
  • TodosHelper
  • TreeHelper
  • UserCalloutsHelper
  • IdeHelper
  • JobsHelper
  • InternalRedirect
  • RoutableActions
  • ServiceParams
  • BoardsResponses
  • CycleAnalyticsParams
  • IssuableActions
  • IssuableCollections
  • EE::Gitlab::GitAccess

Credits: !21746 (comment 260541120)

Does this MR meet the acceptance criteria?

Conformity

Closes #39499 (closed)

Edited by Thong Kuah

Merge request reports