Skip to content

Setup multiple milestones

Mario de la Ossa requested to merge 36032-multiple-milestone-storage into master

What does this MR do?

Sets up the necessary storage for multiple milestones for Issues and MergeRequests

Initially we're just writing to both the old and the new location

We still have to change all SQL code that depends on milestone_id, especially all scopes (of which there is a BUNCH)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Database checklist

When adding migrations:

  • Updated db/schema.rb
  • Added a down method so the migration can be reverted
  • Added the output of the migration(s) to the MR body
  • Added tests for the migration in spec/migrations if necessary (e.g. when migrating data)
  • Added rollback procedure. Include either a rollback procedure or description how to rollback changes

When adding tables:

  • Ordered columns based on the Ordering Table Columns guidelines
  • Added foreign keys to any columns pointing to data in other tables
  • Added indexes for fields that are used in statements such as WHERE, ORDER BY, GROUP BY, and JOINs

Refs #36032 (closed)

Edited by Mario de la Ossa

Merge request reports

Loading