Skip to content

Enable factorybot cop

Ryan Cobb requested to merge rc/rubocop-factorybot into master

What does this MR do?

This MR enables FactoryBot/FactoryClassName and FactoryBot/CreateList cops. They were disabled in the upgrade of gitlab-styles from 2.7.0 to 3.1.0 because they were causing violations.

For more info on the cops see:

See #42182 (closed) for other cops that were disabled.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading