Revert "Merge branch '118845-build-qa-image-job-does-not-work-in-security-repo' into 'master'"
What does this MR do?
The previous change in !22067 (merged) to use gitlab-org/gitlab instead of ${CI_PROJECT_PATH} has broken gitlab-foss. The reason is that in gitlab-foss, the job looks for gitlab-org/gitlab/gitlab/gitlab-ce-qa:master. This ce image is not pushed to gitlab-org/gitlab container registry.
Now that gitlab-org/security/gitlab has a container registry and it has its own gitlab-ee-qa:master, we can actually revert the change in !22067 (merged).
Update: As demonstrated in https://gitlab.com/gitlab-org/security/gitlab/merge_requests/27, simply reverting does not solve the problem due to private container registry requiring log in.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team