Ensure that instance statistics links are only displayed if a user has access to the features
requested to merge 36017-move-analytics-out-of-more-in-top-navbar-and-merge-with-instance-statistics into master
What does this MR do?
This MR fixes a bug which allows instance statistics links within the analytics namespace to be visible when the features are not available for a user. Clicking the links results in a 404. We want to hide the links in this case
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Brandon Labuschagne