Fix spacing and UI on Recent Deliveries section of Project Services
requested to merge 118791-clean-up-spacing-on-recent-deliveries-section-of-project-service-settings into master
What does this MR do?
Issue #118791 (closed)
Example URL: http://localhost:3000/gitlab-org/gitlab-shell/-/services/jenkins/edit
- Remove negative bottom margin on
.footer-block
that pushes content up. Add 32px top margin to the Recent Deliveries section. - Use
.badge
instead of.label
for the status code to have rounded corners. - Use a label method to show just "Error" instead of "internal error" on the frontend.
Screenshots
Before | After |
---|---|
.footer-block
Other places that use Below are a few places that use the .footer-block
CSS class. This MR made a change to the bottom margin so below are screenshots to show that those do not have visual regressions. Thankfully, most of them are meant to be at the bottom of the page (aka "footer") so there is only whitespace below.
:group/:project/merge_requests/3/edit
Edit an MR
:group/:project/pipeline_schedules/new
Schedule a new pipeline
/admin/application_settings/services/62/edit
Admin service templates
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖