Resolve "NoMethodError: undefined method `sort_by_attribute' for nil:NilClass"
requested to merge 197143-nomethoderror-undefined-method-sort_by_attribute-for-nil-nilclass into master
What does this MR do?
I discovered that if we call GroupMembersFinder
with root group and include_relations: [:inherited]
params it will return nil instead of relation. This was causing 500 error as controller or finder itself was expecting relation for further filtering.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #197143 (closed)