Contain registry expiration policy adjust loader and use toast
requested to merge 196843-fix-giant-loader-in-container-registry-expiration-policy-settings into master
What does this MR do?
This MR removes the giant loader and move it inside the submit button, it also swaps the top page flash for gl-toast as per designs guidelines
Screenshots
Loader
note: in the video the developer tools are used to slow down the request and show the loader for an appreciable time
Toasts
note: in the video the developer tools are used to have the various requests fail or succeed
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Refers to #196843 (closed)
Edited by Yorick Peterse