Add 'shard' label to 'job_queue_duration_seconds' histogram metric
What does this MR do?
Adds a mechanism to distinguish different kinds of Shared Runners in the CI queue times histogram metric.
Since Runner entity already have a tag
concept, we've decided to introduce a specific tag prefix, that will be used to assign metric related shards
information.
Because of the possible cardinality of generated Prometheus metrics, we add this mechanism only when the Runner is an instance type (like the existing jobs_running_for_project
label). For non-shared runners the shard
label will always be set to default
.
This is a requirement to handle https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/9049.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team