Displayed number of pipeline changes as page loads
What does this MR do?
For issue #32290 (closed)
When clicking into the pipeline table display(#commit-pipeline-table-view) from the merge request tab set, the pipeline amount badge is assigned a defunct event listener that updates the pipeline count to the amount per page returned via the pagination call.
The pagination steps, seems to be broken, returning incorrect values per page selected(see screenshots). I.e. the UI renders 5 buttons but there are only values for the first 3(30/30 and 23).
This merge fix's this issue by removing the offending event listener and showing the correct number of pipelines that is given on the initial page load.
Regardless of the amount returned from this pagination call, from the UX perspective it makes more sense for a user to see the total amount of pipelines for this merge within the tab. Adding a Amount per page could be considered a separate improvement.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
There has been a single test added to commit/pipelines/pipelines.spec.js to ensure that the badge number remains constant regardless of pagination.